Skip to content

DOC: small whatsnew updates #18219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2017
Merged

DOC: small whatsnew updates #18219

merged 1 commit into from
Nov 11, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Nov 10, 2017

No description provided.

@jreback jreback added the Docs label Nov 10, 2017
@jreback jreback added this to the 0.22.0 milestone Nov 10, 2017
- Better support for ``Dataframe.style.to_excel()`` output with the ``xlsxwriter`` engine. (:issue:`16149`)
- :func:`pd.tseries.frequencies.to_offset()` now accepts leading '+' signs e.g. '+1h'. (:issue:`18171`)
- Better support for :func:`Dataframe.style.to_excel` output with the ``xlsxwriter`` engine. (:issue:`16149`)
- :func:`pandas.tseries.frequencies.to_offset` now accepts leading '+' signs e.g. '+1h'. (:issue:`18171`)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisvandenbossche @TomAugspurger I can't get this one to render, what is wrong here?

Copy link
Contributor

@TomAugspurger TomAugspurger Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like to_offset isn't in api.rst. It would need an

.. autosummary:
   :toctree: generated/

   tseries.frequencies.to_offset

I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh, and that's actually a pretty useful function, should prob be in pd namespace

.. autosummary::
:toctree: generated/

DateOffset
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these weren't anywhere :< (not the complete list as didn't put up businesss ones).....

@@ -41,10 +41,10 @@ Other API Changes
^^^^^^^^^^^^^^^^^

- ``NaT`` division with :class:`datetime.timedelta` will now return ``NaN`` instead of raising (:issue:`17876`)
- All-NaN levels in ``MultiIndex`` are now assigned float rather than object dtype, coherently with flat indexes (:issue:`17929`).
- All-NaN levels in a ``MultiIndex`` are now assigned ``float`` rather than ``object`` dtype, promoting consistency with ``Index`` (:issue:`17929`).
- :class:`Timestamp` will no longer silently ignore unused or invalid `tz` or `tzinfo` keyword arguments (:issue:`17690`)
- :class:`Timestamp` will no longer silently ignore invalid `freq` arguments (:issue:`5168`)
Copy link
Member

@jschendel jschendel Nov 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the lines 45/46: tz, tzinfo, and freq should have two backticks instead of one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@jreback
Copy link
Contributor Author

jreback commented Nov 11, 2017

this may not be exactly correct from a doc perspective (and prob adds some warnings), but getting the data in the right place for now.

@jreback jreback merged commit b37e4f5 into pandas-dev:master Nov 11, 2017
@jorisvandenbossche
Copy link
Member

A bit late (could also keep such things open a bit longer), but:

  • I would for now not add more classes to the api.rst until we figure out the api issues (how to not add all its members), so the task to fix that does not become larger
  • in general when adding things to api.rst, we should make sure they have actually docstrings. Now almost all the classes added have empty pages.

@jreback
Copy link
Contributor Author

jreback commented Nov 11, 2017

right this was mainly to get things started

No-Stream pushed a commit to No-Stream/pandas that referenced this pull request Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants